Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Libdb actor #1319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Libdb actor #1319

wants to merge 1 commit into from

Conversation

fila43
Copy link
Contributor

@fila43 fila43 commented Dec 9, 2024

Since libdb was removed from RHEL-10, we want to inform users about such a change and provide guidance for database migration.

Copy link

github-actions bot commented Dec 9, 2024

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@fila43 fila43 force-pushed the libdb branch 5 times, most recently from 9240315 to 08c89b7 Compare December 9, 2024 13:52
@pirat89 pirat89 added this to the 8.10/9.6 milestone Dec 9, 2024
from leapp.tags import ChecksPhaseTag, IPUWorkflowTag


class PostgresqlCheck(Actor):
Copy link
Member

@pirat89 pirat89 Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fila43 copy paste err? :-)

Suggested change
class PostgresqlCheck(Actor):
class LibdbCheck(Actor):

Comment on lines +7 to +18
report_libdb_inst_summary = (
'Libdb was marked as deprecated in RHEL-9 and in RHEL-10 is not included anymore.'
' There are a couple of alternatives in RHEL-10; the applications that'
' depend on libdb will not work. Such applications must implement another'
' type of backend storage. And migrate existing data to the new database'
' format; for the conversion, the tool db_converter from the libdb-utils'
' rpm could be used.'
)

report_libdb_inst_hint = (
'Back up your data before proceeding with the data upgrade/migration.'
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's sync about the wording (during next week?) yet.

@pirat89
Copy link
Member

pirat89 commented Jan 17, 2025

It needs just renamed actor's class and I think that summary+remediation will need some attention yet, but it's good otherwise.

@pirat89 pirat89 added the enhancement New feature or request label Jan 17, 2025
@pirat89 pirat89 self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants