-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Libdb actor #1319
base: main
Are you sure you want to change the base?
Add Libdb actor #1319
Conversation
Resolves: RHEL-35618
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
Note that first time contributors cannot run tests automatically - they need to be started by a reviewer. It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
See other labels for particular jobs defined in the Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
9240315
to
08c89b7
Compare
from leapp.tags import ChecksPhaseTag, IPUWorkflowTag | ||
|
||
|
||
class PostgresqlCheck(Actor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fila43 copy paste err? :-)
class PostgresqlCheck(Actor): | |
class LibdbCheck(Actor): |
report_libdb_inst_summary = ( | ||
'Libdb was marked as deprecated in RHEL-9 and in RHEL-10 is not included anymore.' | ||
' There are a couple of alternatives in RHEL-10; the applications that' | ||
' depend on libdb will not work. Such applications must implement another' | ||
' type of backend storage. And migrate existing data to the new database' | ||
' format; for the conversion, the tool db_converter from the libdb-utils' | ||
' rpm could be used.' | ||
) | ||
|
||
report_libdb_inst_hint = ( | ||
'Back up your data before proceeding with the data upgrade/migration.' | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's sync about the wording (during next week?) yet.
It needs just renamed actor's class and I think that summary+remediation will need some attention yet, but it's good otherwise. |
Since libdb was removed from RHEL-10, we want to inform users about such a change and provide guidance for database migration.